rakeshadr commented on a change in pull request #1607:
URL: https://github.com/apache/ozone/pull/1607#discussion_r536068807
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystemV1.java
##########
@@ -308,78 +300,6 @@ protected void testRenameDirToItsOwnSubDir() throws
Exception {
}
}
- /**
- * Case-5) If new destin '/dst/source' exists then throws exception.
- * If destination is a directory then rename source as sub-path of it.
- * <p>
- * For example: rename /a to /b will lead to /b/a. This new path should
- * not exist.
- */
- protected void testRenameToNewSubDirShouldNotExist() throws Exception {
- // Case-5.a) Rename directory from /a to /b.
- // created /a
- final Path aSourcePath = new Path(fs.getUri().toString() + "/a");
- fs.mkdirs(aSourcePath);
-
- // created /b
- final Path bDestinPath = new Path(fs.getUri().toString() + "/b");
- fs.mkdirs(bDestinPath);
-
- // Add a sub-directory '/b/a' to '/b'. This is to verify that rename
- // throws exception as new destin /b/a already exists.
- final Path baPath = new Path(fs.getUri().toString() + "/b/a");
- fs.mkdirs(baPath);
-
- try {
- fs.rename(aSourcePath, bDestinPath);
- Assert.fail("Should fail as new destination dir exists!");
- } catch (OMException ome) {
- // expected as new sub-path /b/a already exists.
- assertEquals(ome.getResult(),
OMException.ResultCodes.KEY_ALREADY_EXISTS);
- }
-
- // Case-5.b) Rename file from /a/b/c/file1 to /a.
- // Should be failed since /a/file1 exists.
- final Path abcPath = new Path(fs.getUri().toString() + "/a/b/c");
- fs.mkdirs(abcPath);
- Path abcFile1 = new Path(abcPath, "/file1");
- ContractTestUtils.touch(fs, abcFile1);
-
- final Path aFile1 = new Path(fs.getUri().toString() + "/a/file1");
- ContractTestUtils.touch(fs, aFile1);
-
- final Path aDestinPath = new Path(fs.getUri().toString() + "/a");
-
- try {
- fs.rename(abcFile1, aDestinPath);
- Assert.fail("Should fail as new destination file exists!");
- } catch (OMException ome) {
- // expected as new sub-path /b/a already exists.
- assertEquals(ome.getResult(),
OMException.ResultCodes.KEY_ALREADY_EXISTS);
- }
- }
-
- /**
- * Case-6) Rename directory to an existed file, should be failed.
- */
- protected void testRenameDirToFile() throws Exception {
- final String root = "/root";
- Path rootPath = new Path(fs.getUri().toString() + root);
- fs.mkdirs(rootPath);
-
- Path file1Destin = new Path(fs.getUri().toString() + root + "/file1");
- ContractTestUtils.touch(fs, file1Destin);
- Path abcRootPath = new Path(fs.getUri().toString() + "/a/b/c");
- fs.mkdirs(abcRootPath);
- try {
- fs.rename(abcRootPath, file1Destin);
- Assert.fail("key already exists /root_dir/file1");
- } catch (OMException ome) {
- // expected
- assertEquals(ome.getResult(),
OMException.ResultCodes.KEY_ALREADY_EXISTS);
Review comment:
IIUC, you are suggesting to retain this test. Actually, I haven't
removed this test instead I avoided overriding #testRenameDirToFile in
TestOzoneFileSystemV1. Since TestOzoneFileSystemV1 extends TestOzoneFileSystem,
it will run from the parent class. Does this fine for you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
