bharatviswa504 commented on a change in pull request #1555:
URL: https://github.com/apache/ozone/pull/1555#discussion_r536251623
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -1275,7 +1275,7 @@ private void startTrashEmptier(Configuration conf) throws
IOException {
// configuration for the FS instance that points to a root OFS uri.
// This will ensure that it will cover all volumes and buckets
- Configuration fsconf = new Configuration();
+ Configuration fsconf = new OzoneConfiguration();
Review comment:
From my understanding, we need to use OzoneConfiguration, as
OzoneConfiguration activates ozone-default.xml
public static void activate() {
// adds the default resources
Configuration.addDefaultResource("hdfs-default.xml");
Configuration.addDefaultResource("hdfs-site.xml");
Configuration.addDefaultResource("ozone-default.xml");
}
By using Configuration, defaults of Ozone will not be loaded. And also as we
have for each config, we have defaults defined in Java code that should also be
fine.
Using OzoneConfiguration is better IMHO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
