lamber-ken commented on a change in pull request #1673:
URL: https://github.com/apache/ozone/pull/1673#discussion_r538124467
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java
##########
@@ -351,7 +352,7 @@ private OzoneConsts() {
public static final String GDPR_FLAG = "gdprEnabled";
public static final String GDPR_ALGORITHM_NAME = "AES";
public static final int GDPR_DEFAULT_RANDOM_SECRET_LENGTH = 16;
- public static final String GDPR_CHARSET = "UTF-8";
+ public static final String GDPR_CHARSET = StandardCharsets.UTF_8.name();
Review comment:
I think keep `GDPR_CHARSET` here is better, because define constants
about GDPR here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
