errose28 commented on a change in pull request #1664:
URL: https://github.com/apache/ozone/pull/1664#discussion_r538863124
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java
##########
@@ -1547,6 +1547,32 @@ public boolean recoverTrash(String volumeName, String
bucketName,
return recoverResponse.getResponse();
}
+ @Override
+ public long prepareOzoneManager(long flushWaitTimeout,
+ long flushCheckInterval) throws IOException {
+ Preconditions.checkArgument(flushWaitTimeout > 0,
+ "flushWaitTimeout has to be > zero");
+
+ Preconditions.checkArgument(flushCheckInterval > 0 &&
+ flushCheckInterval < flushWaitTimeout / 2,
+ "flushCheckInterval has to be > zero and < half of " +
+ "flushWaitTimeout to make sense.");
Review comment:
Since the timeout command is now hidden this is probably okay.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
