rakeshadr commented on a change in pull request #1668:
URL: https://github.com/apache/ozone/pull/1668#discussion_r538958195
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyDeleteRequestV1.java
##########
@@ -149,9 +149,7 @@ public OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager,
omBucketInfo = getBucketInfo(omMetadataManager, volumeName, bucketName);
long quotaReleased = sumBlockLengths(omKeyInfo);
- // update usedBytes atomically.
- omVolumeArgs.getUsedBytes().add(-quotaReleased);
- omBucketInfo.getUsedBytes().add(-quotaReleased);
+ omBucketInfo.incrUsedBytes(-quotaReleased);
Review comment:
Thanks a lot @bharatviswa504 for reminding this point again. Since this
requires more deeper discussion I've created HDDS-4565 jira.
Like we discussed in offline chat, it helps to unblock other PRs by fixing
compilation errors in the branch(it occurred due to the recent rebase). I am
changing the jira description as well reflecting the compilation error part.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
