xiaoyuyao commented on a change in pull request #1662:
URL: https://github.com/apache/ozone/pull/1662#discussion_r539039125
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMSecurityProtocolServer.java
##########
@@ -192,6 +195,33 @@ public String getCACertificate() throws IOException {
}
}
+ /**
+ *
+ * @param role - node role: OM/SCM/DN.
+ * @param startSerialId - start certificate serial id.
+ * @param count - max number of certificates returned in a batch.
+ * @param isRevoked - whether list for revoked certs only.
+ * @return
+ * @throws IOException
+ */
+ @Override
+ public List<String> listCertificate(HddsProtos.NodeType role,
+ long startSerialId, int count, boolean isRevoked) throws IOException {
+ List<X509Certificate> certificates =
+ certificateServer.listCertificate(role, startSerialId, count,
+ isRevoked);
+ List<String> results = new ArrayList<>(certificates.size());
+ for (X509Certificate cert : certificates) {
+ try {
+ String certStr = CertificateCodec.getPEMEncodedString(cert);
+ results.add(certStr);
+ } catch (SCMSecurityException e) {
+ LOGGER.error("listCertificate fail to encode certificate.", e);
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
