linyiqun commented on a change in pull request #1693:
URL: https://github.com/apache/ozone/pull/1693#discussion_r541644472
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java
##########
@@ -193,7 +193,6 @@ public OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager,
long scmBlockSize = ozoneManager.getScmBlockSize();
int factor = omKeyInfo.getFactor().getNumber();
- omVolumeArgs = getVolumeInfo(omMetadataManager, volumeName);
omBucketInfo = getBucketInfo(omMetadataManager, volumeName, bucketName);
Review comment:
Same comment for above.
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequest.java
##########
@@ -279,7 +279,6 @@ public OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager,
.collect(Collectors.toList());
omKeyInfo.appendNewBlocks(newLocationList, false);
- omVolumeArgs = getVolumeInfo(omMetadataManager, volumeName);
Review comment:
Why we not remove omVolumeArgs variable defined in this method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
