xiaoyuyao commented on a change in pull request #1703:
URL: https://github.com/apache/ozone/pull/1703#discussion_r543613268
##########
File path:
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java
##########
@@ -703,7 +703,14 @@ public boolean mkdirs(Path f, FsPermission permission)
throws IOException {
@Override
public long getDefaultBlockSize() {
- return (long) getConf().getStorageSize(
+ Configuration conf = getConf();
+ ConfigurationSource source;
Review comment:
NIT: can we wrap this as a helper function as I can see the initialize()
has similar logic.
##########
File path:
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java
##########
@@ -703,7 +703,14 @@ public boolean mkdirs(Path f, FsPermission permission)
throws IOException {
@Override
public long getDefaultBlockSize() {
Review comment:
We need a fix for this in
BasicRootedOzoneFileSystem#getDefaultBlockSize() as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
