captainzmc commented on pull request #1677:
URL: https://github.com/apache/ozone/pull/1677#issuecomment-746150718


   > > > The default will be -2, all older buckets will have -2, new buckets 
created after this feature will have -1. So, if some one sets >quota on older 
buckets in this way, we can figure it out, just an idea saying here.
   > > 
   > > 
   > > If we want to disallow the quota support for older buckets, one idea to 
do at code level.
   > 
   > User using old Ozone version may still has the desire to use the new Quota 
feature. It's better not shut the door completely.
   > @adoroszlai , I'm not sure if it's feasible that we provide a option of 
calculating the bytesInUsed for each bucket during 1.0.0 -> 1.1. upgrade to 
user? So that user has the choice either tolerate the inaccurate bytesInUsed or 
a relative longer upgrade time to get accurate bytesInUsed of buckets.
   
   Hi @ChenSammi, I think it's dangerous recalculating usedBytes in upgrade . 
If the amount of data is too large, it will greatly increase the time, and if 
the processing is not good, it will cause the upgrade to fail.
   If we want use Quota in old buckets, we can add a command to recalculate 
bucket usedBytes to minimize the impact.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to