bharatviswa504 commented on a change in pull request #1682:
URL: https://github.com/apache/ozone/pull/1682#discussion_r545609085
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMAllocateBlockRequest.java
##########
@@ -192,6 +193,17 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager,
KEY_NOT_FOUND);
}
+ if (ozoneManager.getEnableFileSystemPaths()) {
+ // Ensure the parent exist.
+ if (!"".equals(OzoneFSUtils.getParent(keyName))
Review comment:
>Is there anything else, that can be checked? Yahh, there might be some
issue because of non atomic behaviour delete/rename. Will pulling this check
inside lock, solve them or lead to a better state?
As due to non-atomic behavior whole path check can help here. But this issue
will be solved once HDDS-2939 comes in. And also this check is done under lock
even right now. Let's have this way for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
