amaliujia commented on a change in pull request #1723:
URL: https://github.com/apache/ozone/pull/1723#discussion_r546189920
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketSetPropertyRequest.java
##########
@@ -228,6 +228,13 @@ public boolean checkQuotaBytesValid(OMMetadataManager
metadataManager,
throws IOException {
long quotaInBytes = omBucketArgs.getQuotaInBytes();
+ if (quotaInBytes == OzoneConsts.QUOTA_RESET &&
+ omVolumeArgs.getQuotaInBytes() != OzoneConsts.QUOTA_RESET) {
+ throw new OMException("Before clear bucket quotaInBytes," +
Review comment:
Nit: will it better to use more descriptive names than variable names.
For example, replace `quotaInBytes` by space quota?
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketSetPropertyRequest.java
##########
@@ -259,9 +266,16 @@ public boolean checkQuotaBytesValid(OMMetadataManager
metadataManager,
}
public boolean checkQuotaNamespaceValid(OmVolumeArgs omVolumeArgs,
- OmBucketArgs omBucketArgs) {
+ OmBucketArgs omBucketArgs) throws IOException{
long quotaInNamespace = omBucketArgs.getQuotaInNamespace();
+ if (quotaInNamespace == OzoneConsts.QUOTA_RESET &&
+ omVolumeArgs.getQuotaInNamespace() != OzoneConsts.QUOTA_RESET) {
+ throw new OMException("Before clear bucket " +
+ "quotaInNamespace, volume quotaInNamespace need to be clear first.",
Review comment:
Nit: same, maybe replace `quotaInNamespace` by namespace quota?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
