captainzmc commented on pull request #1746: URL: https://github.com/apache/ozone/pull/1746#issuecomment-752830548
> @captainzmc , If setting quota to 0 is not allowed now, can we rollback unrelated change in this PR? @linyiqun Thanks for the tip. I think currently all changes to this PR are required。 First we need to be able to distinguish whether the user sets quota to 0 (users may not specify Quoat when creating volumes and buckets, long is undefined as 0 by default and should be successful), and then judge the validity based on this. Therefore, we need to change quotaInNamespace from long to String. In addition, it is also possible for users to specify either quotaInBytes or quotaInNamespace separately. In addition, many cases of original UT are not covered, so I made a supplement separately. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
