elek commented on pull request #1600:
URL: https://github.com/apache/ozone/pull/1600#issuecomment-756029374


   Thanks the update @sadanand48 
   
   This part seems to be suspicious:
   
   ```
    179   │   private void writeOnPipeline(OzoneConfiguration ozoneConf,
    180   │       List<Pipeline> pipelines) throws IOException {
    181   │     LOG.info("Inside write Pipeline and pipeline size" + 
pipelines.size());
    182   │     xceiverClients = new ArrayList<>();
    183   │     for (Pipeline p: pipelines){
    184   │       init();
    185   │       LOG.info("run test on pipeline" + p.getId().toString());
    186   │       XceiverClientSpi clientSpi = 
xceiverClientManager.acquireClient(p);
    187   │       xceiverClients.add(clientSpi);
    188   │       runTest(clientSpi);
    189   │     }
    190   │   }
    ```
   
   It has multiple `init()` calls which reset all the counters. `runTest` 
should be called only once IMHO. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to