runzhiwang commented on a change in pull request #1725:
URL: https://github.com/apache/ozone/pull/1725#discussion_r553317733
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMStateMachine.java
##########
@@ -89,4 +99,15 @@ private Message process(final SCMRatisRequest request)
}
}
+ @Override
+ public long takeSnapshot() throws IOException {
+ LOG.info("Current Snapshot Index {}", getLastAppliedTermIndex());
+ long startTime = Time.monotonicNow();
+ TermIndex lastTermIndex = getLastAppliedTermIndex();
+ long lastAppliedIndex = lastTermIndex.getIndex();
+ transactionBuffer.flush();
+ LOG.debug("SCM takeSnapshot: {} took {} ms",
+ Time.monotonicNow() - startTime);
+ return lastAppliedIndex;
Review comment:
Maybe flush should return SCMTransactionInfo, and this return
SCMTransactionInfo#transactionIndex ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
