amaliujia commented on a change in pull request #1781:
URL: https://github.com/apache/ozone/pull/1781#discussion_r555582651
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##########
@@ -293,6 +295,13 @@ public void setVolumeQuota(String volumeName, long
quotaInNamespace,
HddsClientUtils.verifyResourceName(volumeName);
verifyCountsQuota(quotaInNamespace);
verifySpaceQuota(quotaInBytes);
+ // If the volume is old, we need to remind the user on the client side
+ // that it is not recommended to enable quota.
+ OmVolumeArgs omVolumeArgs = ozoneManagerClient.getVolumeInfo(volumeName);
+ if (omVolumeArgs.getQuotaInNamespace() == OLD_QUOTA_DEFAULT) {
+ LOG.warn("Volume: {} is a old volume, usedNamespace may be " +
Review comment:
I feel like "old" does not provide enough context.
Will it better to say that " {} is a volume created before version 1.1.0"?
Same for the following warning messages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
