hanishakoneru commented on a change in pull request #1793:
URL: https://github.com/apache/ozone/pull/1793#discussion_r557596244



##########
File path: 
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java
##########
@@ -343,6 +343,7 @@ private OzoneConsts() {
 
   // Default OMServiceID for OM Ratis servers to use as RaftGroupId
   public static final String OM_SERVICE_ID_DEFAULT = "omServiceIdDefault";
+  public static final String OM_DEFAULT_NODE_ID = "om1";
 
   // Dummy OMNodeID for OM Clients to use for a non-HA OM setup
   public static final String OM_NODE_ID_DUMMY = "omNodeIdDummy";

Review comment:
       OM_NODE_ID_DUMMY was being used just as a dummy nodeId in 
OMFailoverProxyProvider for non-HA cluster.
   But now that we have a default, we should remove the dummy. It would not 
affect the client in anyway as this is only for the non-HA and also. 
   Thanks for pointing this out Arpit. I will update the PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to