ChenSammi commented on a change in pull request #1785:
URL: https://github.com/apache/ozone/pull/1785#discussion_r559538459
##########
File path:
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestPipelineManagerImpl.java
##########
@@ -149,12 +150,16 @@ public void testCreatePipelineShouldFailOnFollower()
throws Exception {
@Test
public void testUpdatePipelineStates() throws Exception {
PipelineManagerV2Impl pipelineManager = createPipelineManager(true);
+ Table<PipelineID, Pipeline> pipelineStore = SCMDBDefinition
+ .PIPELINES.getTable(dbStore);
Review comment:
Indent is incorrent.
##########
File path:
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestPipelineManagerImpl.java
##########
@@ -149,12 +150,16 @@ public void testCreatePipelineShouldFailOnFollower()
throws Exception {
@Test
public void testUpdatePipelineStates() throws Exception {
PipelineManagerV2Impl pipelineManager = createPipelineManager(true);
+ Table<PipelineID, Pipeline> pipelineStore = SCMDBDefinition
+ .PIPELINES.getTable(dbStore);
pipelineManager.allowPipelineCreation();
Pipeline pipeline = pipelineManager.createPipeline(
HddsProtos.ReplicationType.RATIS, HddsProtos.ReplicationFactor.THREE);
Assert.assertEquals(1, pipelineManager.getPipelines().size());
Assert.assertTrue(pipelineManager.containsPipeline(pipeline.getId()));
Assert.assertEquals(ALLOCATED, pipeline.getPipelineState());
+ Assert.assertEquals(ALLOCATED, pipelineStore.get(pipeline.getId())
+ .getPipelineState());
Review comment:
same as above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
