jojochuang commented on pull request #1820: URL: https://github.com/apache/ozone/pull/1820#issuecomment-763498437
Great question.... IMO we want a single RDBMetric instance. With the current architecture we will see thousands of containers per DataNode. Having metrics for each and every container... that seems too excessive to me. Plus, the metrics are kept only during the lifetime of a container. I feel like we want a singleton RDBMetric for the duration of the process. @vivekratnavel thoughts? you wrote the original code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
