ferhui commented on pull request #1823: URL: https://github.com/apache/ozone/pull/1823#issuecomment-764152253
> So the reason to convert nano to millis is because that most of the unit are already millis? > > Could there be a reason that nano as unit actually could be better? @amaliujia Thanks for comments. As mentioned in JIRA HDDS-4725, I think there are some reasons that it's better to use millis. - Mostly the metrics are the order of millisecond. - It's millis in hadoop, and It's easier to understand the metric. - there are both nano and milli right now, we need to unify them. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
