GlenGeng edited a comment on pull request #1828: URL: https://github.com/apache/ozone/pull/1828#issuecomment-764251565
cc @runzhiwang, he is currently working on integrating DeleteBlockLog with ratis. This solution is fine to me. Thanks for this smart solution! In SCM HA, we decided to use the distributed sequence id <term, counter> as the txnId, which can easily maintain monotonically increasing property. Meanwhile in SCM running without ratis, we do not have term, thus need to leverage this solution to provide a monotonically increasing txnId. As mentioned by @bshashikant, we might need support switch from HA (using Ratis) to non-HA (not using Ratis), it will be hard to maintain the monotonically increasing property between the two kind of txnIds. For the txnId, since SCM HA will keep the DeletedBlocksTXTable to be the same across SCMs, I consider we don't need the distributed sequence id solution any more, this solution will be sufficient. What do you think @runzhiwang @bshashikant @amaliujia @nandakumar131 ? Attention that we might meet same problem for containerID and localID generation if we need to support switch ratis SCM to non-ratis SCM. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
