amaliujia commented on a change in pull request #1837:
URL: https://github.com/apache/ozone/pull/1837#discussion_r563394486
##########
File path: hadoop-hdds/interface-client/src/main/proto/hdds.proto
##########
@@ -158,7 +158,7 @@ message NodePool {
/**
* LifeCycleState for SCM object creation state machine:
- * ->Allocated: allocated on SCM but clean has not started creating it yet.
+ * ->Allocated: allocated on SCM but client has not started creating it yet.
* ->Creating: allocated and assigned to client to create but not ack-ed
yet.
* ->Open: allocated on SCM and created on datanodes and ack-ed by a client.
* ->Close: container closed due to space all used or error?
Review comment:
Nit: as this PR is fixing typo, maybe remove the question mark of
`Close: container closed due to space all used or error?`
##########
File path: hadoop-hdds/interface-client/src/main/proto/hdds.proto
##########
@@ -158,7 +158,7 @@ message NodePool {
/**
* LifeCycleState for SCM object creation state machine:
- * ->Allocated: allocated on SCM but clean has not started creating it yet.
+ * ->Allocated: allocated on SCM but client has not started creating it yet.
* ->Creating: allocated and assigned to client to create but not ack-ed
yet.
* ->Open: allocated on SCM and created on datanodes and ack-ed by a client.
* ->Close: container closed due to space all used or error?
Review comment:
Nit: as this PR is fixing typo, maybe remove the question mark in
`Close: container closed due to space all used or error?`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
