runzhiwang commented on a change in pull request #1780: URL: https://github.com/apache/ozone/pull/1780#discussion_r563440180
########## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMStateMachine.java ########## @@ -152,6 +152,10 @@ public void notifyLeaderChanged(RaftGroupMemberId groupMemberId, LOG.info("current SCM becomes leader of term {}.", term); scm.getScmContext().updateIsLeaderAndTerm(true, term); + if (scm.getScmContext().isLeader()) { Review comment: you are right, we do not need this check. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org