ayushtkn commented on a change in pull request #1804: URL: https://github.com/apache/ozone/pull/1804#discussion_r564367193
########## File path: hadoop-ozone/integration-test/pom.xml ########## @@ -103,6 +103,21 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";> <artifactId>junit</artifactId> <scope>test</scope> </dependency> + <dependency> + <groupId>org.junit.jupiter</groupId> + <artifactId>junit-jupiter-api</artifactId> + <scope>test</scope> + </dependency> + <dependency> + <groupId>org.junit.jupiter</groupId> + <artifactId>junit-jupiter-engine</artifactId> + <scope>test</scope> + </dependency> + <dependency> + <groupId>org.junit.vintage</groupId> + <artifactId>junit-vintage-engine</artifactId> + <scope>test</scope> + </dependency> Review comment: 2020.2 is new enough :-) It would create problems for IDE bundled without junit-5 I guess, IntelliJ 2017 or before might get affected. Do you find any issues adding `junit-platform-launcher`? else having support for older IDE's won't hurt. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
