lamber-ken commented on pull request #1834: URL: https://github.com/apache/ozone/pull/1834#issuecomment-768206020
> Thanks the patch @lamber-ken. It looks good to me. As far as I remember we agreed to keep the vendor neutral interface, but support only rocksdb for now. > > Some minor comments: > > Can you please remove the `org.fusesource.leveldbjni` dependency from the pom files if it's no longer required? > > `MetadataStore` is an old interface and replaced by `DBStore` everywhere (the later can support multiple column families). > > Which means that: > > 1. `RocksDBStore`, `RocksDBStoreIterator`, `MetadataStore` and `MetadataStoreBuild` can also be removed (IMHO) > 2. `SQLCLI` can be removed because the functionality is replaced by `ozone debug ldb`. > 3. As `MetdataStore` is not required, the related Genesis tests can be removed `BencMark...` files > > I would suggest including at least the dependency update in this patch(unless leveldb is really required by any other code, it can be removed from `pom.xml`) > > 1 + 3 and 2 can be included in this patch or followup patches... Depends on from your preference. sure, will do, thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
