ayushtkn commented on a change in pull request #1838:
URL: https://github.com/apache/ozone/pull/1838#discussion_r565589232
##########
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/security/TestOzoneBlockTokenSecretManager.java
##########
@@ -329,7 +329,7 @@ private X509Certificate generateExpiredCert(String dn,
KeyPair pair, String algorithm) throws CertificateException,
IllegalStateException, IOException, OperatorCreationException {
Date from = new Date();
- Date to = new Date(from.getTime() + 100L);
+ Date to = from;
return generateTestCert(dn, pair, algorithm, from, to);
Review comment:
For readability better to add a comment explaining why we are passing
`from` for both arguments.
Though trivial assigning unnecessary would have cost and isn't a good
practice IMO
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
