ChenSammi commented on a change in pull request #1701:
URL: https://github.com/apache/ozone/pull/1701#discussion_r565900409
##########
File path:
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java
##########
@@ -75,7 +87,7 @@
@GET
@SuppressFBWarnings
@SuppressWarnings("parameternumber")
- public Response list(
+ public Response get(
Review comment:
The function name doesn't matter. It's the annotation @GET which
defines that this get or list function is called when HTTP GET against bucket
is called.
There are plenty of HTTP GET operations for a bucket, such as list object,
get ACL, each with different parameters.
Before this patch, bucket endpoint only supports bucket list GET. With this
patch, bucket ACL get and bucket list are both supported.
In future, when we need to support another GET operation, we just need to
add more logic to this bucket endpoint get function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]