lamber-ken edited a comment on pull request #1864: URL: https://github.com/apache/ozone/pull/1864#issuecomment-771416016
> Thanks @lamber-ken for getting rid of this code duplication. > > I'd prefer adding a static import for the new utility method instead of importing the class itself: > > ``` > import static org.apache.hadoop.hdds.utils.HddsServerUtil.toIOException; > ``` > > This would keep the code more readable and minimize change. > > The patch is fine in its current form, too. Thanks for your review. Static import may better for constants than methods. Let's leave it just as it is now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
