[ 
https://issues.apache.org/jira/browse/HDDS-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17279536#comment-17279536
 ] 

Nanda kumar commented on HDDS-4797:
-----------------------------------

{code}
M C NP: Null passed for non-null parameter of 
SCMTransactionInfoCodec.fromPersistedFormat(byte[]) in 
org.apache.hadoop.hdds.scm.metadata.TestSCMTransactionInfoCodec.testCodecWithNullDataFromTable()
  At TestSCMTransactionInfoCodec.java:[line 59]

M C NP: Null passed for non-null parameter of 
SCMTransactionInfoCodec.toPersistedFormat(SCMTransactionInfo) in 
org.apache.hadoop.hdds.scm.metadata.TestSCMTransactionInfoCodec.testCodecWithNullDataFromUser()
  At TestSCMTransactionInfoCodec.java:[line 65]

M D RCN: Redundant nullcheck of 
org.apache.hadoop.hdds.scm.pipeline.PipelineStateManager.getPipeline(PipelineID),
 which is known to be non-null in 
org.apache.hadoop.hdds.scm.pipeline.MockPipelineManager.containsPipeline(PipelineID)
  Redundant null check at MockPipelineManager.java:[line 89]

M D ST: Write to static field 
org.apache.hadoop.hdds.scm.pipeline.TestPipelineManagerImpl.conf from instance 
method org.apache.hadoop.hdds.scm.pipeline.TestPipelineManagerImpl.init()  At 
TestPipelineManagerImpl.java:[line 80]

M D ST: Write to static field 
org.apache.hadoop.hdds.scm.pipeline.TestPipelineManagerImpl.maxPipelineCount 
from instance method 
org.apache.hadoop.hdds.scm.pipeline.TestPipelineManagerImpl.init()  At 
TestPipelineManagerImpl.java:[line 91]

M D ST: Write to static field 
org.apache.hadoop.hdds.scm.pipeline.TestPipelineManagerImpl.nodeManager from 
instance method 
org.apache.hadoop.hdds.scm.pipeline.TestPipelineManagerImpl.init()  At 
TestPipelineManagerImpl.java:[line 85]

M D ST: Write to static field 
org.apache.hadoop.hdds.scm.pipeline.TestPipelineManagerImpl.testDir from 
instance method 
org.apache.hadoop.hdds.scm.pipeline.TestPipelineManagerImpl.init()  At 
TestPipelineManagerImpl.java:[line 81]

H D ST: Write to static field 
org.apache.hadoop.hdds.scm.safemode.TestSCMSafeModeManager.queue from instance 
method org.apache.hadoop.hdds.scm.safemode.TestSCMSafeModeManager.setUp()  At 
TestSCMSafeModeManager.java:[line 90]

M D DLS: Dead store to containerIDs in 
org.apache.hadoop.ozone.TestStorageContainerManager.testBlockDeletionTransactions()
  At TestStorageContainerManager.java:[line 289]

M D DLS: Dead store to reconContainerManager in 
org.apache.hadoop.ozone.recon.TestReconAsPassiveScm.testDatanodeRegistrationAndReports()
  At TestReconAsPassiveScm.java:[line 128]
{code}

> Fix findbugs issues after HDDS-2195
> -----------------------------------
>
>                 Key: HDDS-4797
>                 URL: https://issues.apache.org/jira/browse/HDDS-4797
>             Project: Apache Ozone
>          Issue Type: Sub-task
>            Reporter: Nanda kumar
>            Priority: Major
>
> After spotbugs is enabled with HDDS-2195, there are additional issues 
> reported by findbugs. These issues have to fixed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to