GlenGeng edited a comment on pull request #1903:
URL: https://github.com/apache/ozone/pull/1903#issuecomment-774894654
After diff
`hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestContainerEndpoint.java`
between HDDS-2823 and master, the reason for failure is:
During the merge and conflict fix,
```
void putContainerInfos(int num) throws IOException {
for (int i = 1; i <= num; i++) {
final ContainerInfo info = newContainerInfo(i);
reconContainerManager.getContainerStore().put(new ContainerID(i),
info);
reconContainerManager.getContainerStateManager().addContainerInfo(
i, info, null, null);
}
}
```
is manually replaced by
```
for (int i = 1; i <= num; i++) {
final ContainerInfo info = newContainerInfo(i);
reconContainerManager.addNewContainer(I,
new ContainerWithPipeline(info, pipeline));
}
```
It requires `pipeline` to exist in `ReconPipelineManager`, otherwise
`addNewContainer` will fail, due to pipeline not found exception. The thus the
solution is quite straight forward, add the random generated pipeline into
`ReconPipelineManager`.
BTW
```
// Mock ReconStorageContainerManagerFacade and other SCM related methods
```
it is already removed from master, and during the merge, we just remove it
too.
The fix of `TestReconContainerManager` is due to the same reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
