bshashikant commented on a change in pull request #1722:
URL: https://github.com/apache/ozone/pull/1722#discussion_r572612741
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ha/OMNodeDetails.java
##########
@@ -31,43 +30,36 @@
/**
* This class stores OM node details.
*/
-public final class OMNodeDetails {
- private String omServiceId;
- private String omNodeId;
- private InetSocketAddress rpcAddress;
+public final class OMNodeDetails extends NodeDetails {
private int rpcPort;
- private int ratisPort;
- private String httpAddress;
- private String httpsAddress;
/**
* Constructs OMNodeDetails object.
*/
private OMNodeDetails(String serviceId, String nodeId,
InetSocketAddress rpcAddr, int rpcPort, int ratisPort,
String httpAddress, String httpsAddress) {
- this.omServiceId = serviceId;
- this.omNodeId = nodeId;
- this.rpcAddress = rpcAddr;
+ super(serviceId, nodeId, rpcAddr, ratisPort, httpAddress, httpsAddress);
this.rpcPort = rpcPort;
Review comment:
is there any specific reason to maintain rpc port specifically in
OMNodeDetails? I guess, it can be common for both SCM and OM and we can
maintain it in NodeDetails itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
