xiaoyuyao commented on a change in pull request #1874:
URL: https://github.com/apache/ozone/pull/1874#discussion_r573247521
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMCertStore.java
##########
@@ -70,35 +85,69 @@ public void storeValidCertificate(BigInteger serialID,
}
@Override
- public void revokeCertificate(BigInteger serialID) throws IOException {
+ public Optional<Long> revokeCertificates(
+ List<BigInteger> serialIDs,
+ X509CertificateHolder caCertificateHolder,
+ CRLReason reason,
Review comment:
Can we add a revoke time parameter for this interface method so that we
don't need to modify the interface later to support scheduled revoke? The
caller can pass now() until the scheduled revoke is implemented.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
