lamber-ken commented on pull request #1904:
URL: https://github.com/apache/ozone/pull/1904#issuecomment-776410614
> It is checking for the exception and error message from exception in other
case, which it won't hit post this change.
The exception is from following logic, the logic has been moved to
PipelinePlacementPolicy#getResultSet.
So in TestPipelineUpdataPolicy#testFallBackPickNodes, already use
`Assert.assertNotNull(node);` to check.
If my understanding is wrong, please correct me, thanks
```
if (node == null) {
String msg = String.format("Unable to find fall back node in" +
" pipeline allocation. nodeSet size: %d", nodeSet.size());
LOG.warn(msg);
throw new SCMException(msg,
SCMException.ResultCodes.FAILED_TO_FIND_SUITABLE_NODE);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
