adoroszlai commented on pull request #1701:
URL: https://github.com/apache/ozone/pull/1701#issuecomment-782214286
> The remaining checkstyle warnings are mainly XML content string used for
test which I don't plan to fix.
These should be trivial to fix:
```
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/S3Acl.java
38: Utility classes should not have a public or default constructor.
42: Name 'grantRead' must match pattern
'^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
43: Name 'grantWrite' must match pattern
'^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
44: Name 'grantReadACP' must match pattern
'^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
45: Name 'grantWriteACP' must match pattern
'^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
46: Name 'grantFullControl' must match pattern
'^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
49: Name 'cannedAclHeader' must match pattern
'^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketAcl.java
53: Name 'bucketName' must match pattern
'^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
60: Name 'aclMarker' must match pattern
'^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
```
and these can be fixed by moving XML content to external file(s) under
`hadoop-ozone/s3gateway/src/test/resources`:
```
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketAcl.java
224: Line is longer than 80 characters (found 90).
226: Line is longer than 80 characters (found 100).
231: Line is longer than 80 characters (found 120).
232: Line is longer than 80 characters (found 104).
238: Line is longer than 80 characters (found 112).
239: Line is longer than 80 characters (found 99).
244: Line is longer than 80 characters (found 112).
245: Line is longer than 80 characters (found 98).
250: Line is longer than 80 characters (found 128).
251: Line is longer than 80 characters (found 84).
256: Line is longer than 80 characters (found 120).
257: Line is longer than 80 characters (found 115).
272: Line is longer than 80 characters (found 90).
274: Line is longer than 80 characters (found 100).
279: Line is longer than 80 characters (found 120).
280: Line is longer than 80 characters (found 104).
286: Line is longer than 80 characters (found 120).
287: Line is longer than 80 characters (found 115).
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
