Xushaohong commented on a change in pull request #1942:
URL: https://github.com/apache/ozone/pull/1942#discussion_r579621355
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/SCMConnectionManager.java
##########
@@ -151,8 +152,8 @@ public void addSCMServer(InetSocketAddress address) throws
IOException {
RetryPolicy retryPolicy =
RetryPolicies.retryUpToMaximumCountWithFixedSleep(
- getScmRpcRetryCount(conf),
- 1000, TimeUnit.MILLISECONDS);
+ getScmRpcRetryCount(conf), getScmRpcRetryInterval(conf),
Review comment:
> Can we just reuse default DN heartbeat
interval(HddsConfigKeys#HDDS_HEARTBEAT_INTERVAL_DEFAULT, 30s) rather than
defined a new rpc retry interval here? Would this a better way?
The retry interval is only 1 sec now, which is for quickly connecting the
scm. The default HB interval may be too long.
Actually, the retry count is not working, since the DatanodeStateMachine
keeps retrying after 15 retries finish.
The current retry policy seems still needs to be changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
