adoroszlai commented on pull request #1950: URL: https://github.com/apache/ozone/pull/1950#issuecomment-784368660
> However we should probably move them into a Ozone util class somewhere, so they are more discoverable / reusable. Totally agree. Maybe `JavaUtils` in `hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds`. (Normally I'd suggest keeping the class name from Hadoop in case we might need to copy more code later. But the `Shell` class itself does not seem to be very much related to the Java version check, so I think we can do better.) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
