bshashikant commented on a change in pull request #1953:
URL: https://github.com/apache/ozone/pull/1953#discussion_r581928988



##########
File path: 
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/protocol/ScmBlockLocationProtocol.java
##########
@@ -77,6 +78,11 @@
    */
   ScmInfo getScmInfo() throws IOException;
 
+  /**
+   * Request to add SCM instance to HA group.
+   */
+  boolean addSCM(AddSCMRequest request) throws IOException;

Review comment:
       i was thinking about doing this.. But seems, like OM also uses the block 
client protocol to connect to SCM. That's why reused it. We can discuss over 
this as we move along and conclude.
   
   There has been discussions to merge the block protocol with container 
protocol as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to