bshashikant commented on a change in pull request #1936:
URL: https://github.com/apache/ozone/pull/1936#discussion_r584470909
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/SCMBlockDeletingService.java
##########
@@ -248,4 +248,9 @@ public boolean shouldRun() {
public String getServiceName() {
return SCMBlockDeletingService.class.getSimpleName();
}
+
+ @Override
+ public void stop() {
Review comment:
Yes., but only if the service is stopped.
I think , we don't need to stop the background services while reloading the
SCM state during install snapshot, as reload will only happen on follower and
on followers, these won't do anything on the db. What do you think?
However, a start and stop method in such services are desired so that, all
the registered services can be started and stopped via service manager itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
