swagle commented on a change in pull request #1993:
URL: https://github.com/apache/ozone/pull/1993#discussion_r588546040
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
##########
@@ -540,37 +540,35 @@ public void processLayoutVersionReport(DatanodeDetails
datanodeDetails,
layoutVersionReport.toString().replaceAll("\n", "\\\\n"));
}
- if (layoutVersionReport != null) {
- int scmSlv = scmLayoutVersionManager.getSoftwareLayoutVersion();
- int scmMlv = scmLayoutVersionManager.getMetadataLayoutVersion();
- int dnSlv = layoutVersionReport.getSoftwareLayoutVersion();
- int dnMlv = layoutVersionReport.getMetadataLayoutVersion();
-
- // If the data node slv is > scm slv => log error condition
- if (dnSlv > scmSlv) {
- LOG.error("Rogue data node in the cluster : {}. " +
- "DataNode SoftwareLayoutVersion = {}, SCM " +
- "SoftwareLayoutVersion = {}",
- datanodeDetails.getHostName(), dnSlv, scmSlv);
- }
+ int scmSlv = scmLayoutVersionManager.getSoftwareLayoutVersion();
+ int scmMlv = scmLayoutVersionManager.getMetadataLayoutVersion();
+ int dnSlv = layoutVersionReport.getSoftwareLayoutVersion();
+ int dnMlv = layoutVersionReport.getMetadataLayoutVersion();
+
+ // If the data node slv is > scm slv => log error condition
+ if (dnSlv > scmSlv) {
+ LOG.error("Rogue data node in the cluster : {}. " +
Review comment:
Rouge is generally used in the security context, I'd suggest using
Outdated or something similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
