GlenGeng commented on a change in pull request #2034:
URL: https://github.com/apache/ozone/pull/2034#discussion_r594076855
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMCertStore.java
##########
@@ -56,20 +61,21 @@
/**
* A Certificate Store class that persists certificates issued by SCM CA.
*/
-public class SCMCertStore implements CertificateStore {
+public final class SCMCertStore implements CertificateStore {
private static final Logger LOG =
LoggerFactory.getLogger(SCMCertStore.class);
private SCMMetadataStore scmMetadataStore;
private final Lock lock;
private AtomicLong crlSequenceId;
- public SCMCertStore(SCMMetadataStore dbStore, long sequenceId) {
+ private SCMCertStore(SCMMetadataStore dbStore, long sequenceId) {
this.scmMetadataStore = dbStore;
lock = new ReentrantLock();
crlSequenceId = new AtomicLong(sequenceId);
}
@Override
+ @Replicate
Review comment:
You'd better place `@Replicate` inside the interface `CertificateStore`.
Please check `ContainerStateManagerV2` and `ContainerStateManagerImpl` as an
example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
