adoroszlai commented on a change in pull request #2060:
URL: https://github.com/apache/ozone/pull/2060#discussion_r597895850
##########
File path: .github/workflows/post-commit.yml
##########
@@ -66,6 +68,7 @@ jobs:
if: always()
bats:
runs-on: ubuntu-18.04
+ if: github.event_name != 'pull_request' || github.event.pull_request.draft
== false
Review comment:
Thanks @dineshchitlangia for the review.
Environment variables cannot be used in `jobs.<name>.if`, at least I ran
into error trying to do so: `Unrecognized named-value: 'env'`.
Jobs can use their dependencies' output. We can create a job that produces
output and make all other jobs depend on it. I am planning to do this for
implementing selective CI checks (HDDS-5000). We can make a step in that
direction as part of this PR, but I'm afraid it might seem overkill for
reviewers. ;) Here's what it would look like:
https://github.com/adoroszlai/hadoop-ozone/commit/802c6f963402f76ce6ca20055fa4a8f23aeee6f3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
