hgruck opened a new pull request #2073:
URL: https://github.com/apache/ozone/pull/2073


   ## What changes were proposed in this pull request?
   Currently, PrometheusMetricsSink adds **# TYPE** definition to each metrics 
line even though the metrics are repeatedly appearing in the endpoint due to 
differing in labels, e.g.
   `# TYPE hdds_dispatcher_counter counter
   
hdds_dispatcher_counter{type="PutBlock",hostname="gruck-ozone-1.gruck-ozone.root.hwx.site"}
 0
   ...
   # TYPE hdds_dispatcher_counter counter
   
hdds_dispatcher_counter{type="ReadContainer",hostname="gruck-ozone-1.gruck-ozone.root.hwx.site"}
 0`
   
   Expected format is:
   `# TYPE hdds_dispatcher_counter counter
   
hdds_dispatcher_counter{type="PutBlock",hostname="gruck-ozone-1.gruck-ozone.root.hwx.site"}
 0
   
hdds_dispatcher_counter{type="ReadContainer",hostname="gruck-ozone-1.gruck-ozone.root.hwx.site"}
 0`
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-5010
   
   ## How was this patch tested?
   Unit test added + manually.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to