cku328 commented on a change in pull request #2051:
URL: https://github.com/apache/ozone/pull/2051#discussion_r600253803
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneKeyLocation.java
##########
@@ -39,16 +39,20 @@
* Offset of this key.
*/
private final long offset;
-
+ /**
+ * KeyOffset of this key.
+ */
+ private final long KeyOffset;
Review comment:
```suggestion
private final long keyOffset;
```
use lower camel case: KeyOffset -> keyOffset
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneKeyLocation.java
##########
@@ -39,16 +39,20 @@
* Offset of this key.
*/
private final long offset;
-
+ /**
+ * KeyOffset of this key.
+ */
+ private final long KeyOffset;
/**
* Constructs OzoneKeyLocation.
*/
public OzoneKeyLocation(long containerID, long localID,
- long length, long offset) {
+ long length, long offset) {
Review comment:
Nit: seems like an unnecessary adjustment.
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneKeyLocation.java
##########
@@ -79,4 +83,9 @@ public long getOffset() {
return offset;
}
+ /**
+ * Returns the KeyOffset of this Key.
+ */
+ public long getKeyOffset() { return KeyOffset; }
Review comment:
```suggestion
public long getKeyOffset() {
return keyOffset;
}
```
blocks should have line breaks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
