bharatviswa504 commented on a change in pull request #2000:
URL: https://github.com/apache/ozone/pull/2000#discussion_r600395507
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
##########
@@ -793,7 +880,18 @@ public static boolean scmBootstrap(OzoneConfiguration conf)
// SCM Node info containing hostname to scm Id mappings
// will be persisted into the version file once this node gets added
// to existing SCM ring post node regular start up.
+
+ if(OzoneSecurityUtil.isSecurityEnabled(conf)) {
+ HASecurityUtils.initializeSecurity(scmStorageConfig,
+ scmInfo.getScmId(), config, getScmAddress(scmhaNodeDetails,
conf),
+ false);
+ }
+ scmStorageConfig.setPrimaryScmNodeId(scmInfo.getScmId());
Review comment:
Updated to fix the issue gracefully.
**The current solution in PR is**
1. Removed isLeader check and added a check if it is primary SCM it can
issue SCM signed certificate. So, in case leader changes still newly
bootstrapped SCM can get signed cert.
2. But if the primary is down, it will fail after failover retry count,
instead of after 3 retries to SCM. (Will open a new Jira to address this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
