JacksonYao287 commented on a change in pull request #2079:
URL: https://github.com/apache/ozone/pull/2079#discussion_r600413168
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/MockSCMHAManager.java
##########
@@ -53,6 +53,10 @@ public static SCMHAManager getInstance(boolean isLeader) {
return new MockSCMHAManager(isLeader);
}
+ public static SCMHAManager getInstance(DBTransactionBuffer buffer) {
Review comment:
MockSCMHAManager.getInstance() will always return a SCMHAManager
instance upon ratis, and now i can not build a sequenceIdGenerator upon no
ratis by just setting 'OZONE_SCM_HA_ENABLE_KEY' to false, so the
MockSCMHAManager must have a getInstance method which can return a no-ratis
SCMHAManager
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
##########
@@ -452,6 +452,11 @@ private void initializeSystemManagers(OzoneConfiguration
conf,
clusterMap = new NetworkTopologyImpl(conf);
}
+ /*
+ TODO: setSCMHAManager is only called in tests now, so
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
