xiaoyuyao commented on pull request #1992: URL: https://github.com/apache/ozone/pull/1992#issuecomment-807917241
> @xiaoyuyao , thanks for consolidating native ACL logics. The patch overall looks good. > > Besides some inline comments, there is "TestOmOzoneAclMap.java". > This UT is introduced in [HDDS-4606](https://issues.apache.org/jira/browse/HDDS-4606), which fixed the issue that duplicate default ACLs are added on volume. I don't find existing UT which covers this case. So can you refine the TestOmOzoneAclMap.java to keep it, or add a new duplicate default ACL check UT somewhere in existing test class? Good catch. I've ported the test in the update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
