sumitagrawl commented on code in PR #7520:
URL: https://github.com/apache/ozone/pull/7520#discussion_r1867426965


##########
hadoop-ozone/recon-codegen/src/main/java/org/hadoop/ozone/recon/schema/SchemaVersionTableDefinition.java:
##########
@@ -66,4 +68,16 @@ private void createSchemaVersionTable() throws SQLException {
         .execute();
   }
 
+  /**
+   * Insert the version of the MLV for the table if it doesn't already exist.
+   * @param version The version value to be inserted
+   * @throws SQLException If the insert operation failed
+   */
+  public void insertCurrentVersion(int version) throws SQLException {
+    if (!CHECK_COLUMN_HAS_VALUE.apply(conn, SCHEMA_VERSION_TABLE_NAME, 
"version_number")) {

Review Comment:
   if already have value, do this need make insertion fail, right? or some 
action required as version may not be one as expected.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to