Sarveksha Yeshavantha Raju created HDDS-11854:
-------------------------------------------------
Summary: Improve CLI layout of ozone debug and repair
Key: HDDS-11854
URL: https://issues.apache.org/jira/browse/HDDS-11854
Project: Apache Ozone
Issue Type: Sub-task
Reporter: Sarveksha Yeshavantha Raju
All commands that only work for one component should be under a dedicated
subcommand. Examples:
ozone debug om fso-repair instead of ozone debug fso-repair.
ozone repair quota which should be ozone om repair quota
ozone repair ldb snapshot should be ozone repair om snapshot since it is not a
generic across RocksDB instances.
We probably want to remove ozone repair ldb all together since there are no
plans to support arbitrary modifications to RocksDB per discussion on
https://github.com/apache/ozone/pull/7177
Since debug/repair commands run locally, it is important that they specify the
component that they are intended for.
Commands relevant to one aspect that affects multiple components should be
grouped together. For example:
ozone debug ratis log-parser instead of ozone debug ratislogparser so that we
can add other Ratis debug commands later.
ozone debug ldb should remain a top level command since it should work on any
ozone rocksdb instance.
IMO commands that run over the network should not be part of debug/repair and
should be moved elsewhere. Otherwise it is ambiguous for which commands the
cluster needs to be up when running, and whether kinit is required. We might
want to discuss this more. Examples include:
ozone debug read-replicas which could be moved to an ozone sh key subcommand
ozone debug recover which could be moved somewhere under ozone admin or ozone
sh key. It is not read-only and should not be under debug
This is not an exhaustive list, but rather my attempt to summarize the areas
where we can improve the CLI layout to make it clear where to find commands in
the CLI and what nodes they should be run on.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
