adoroszlai commented on PR #7438: URL: https://github.com/apache/ozone/pull/7438#issuecomment-2516188767
Thanks @ChenSammi for the review. > I run the "mvn dependency:analyze" locally and get following unused dependencies. This patch will remove 4 of them. Shall we remove the rest 3 too？ > > ``` > [WARNING] Unused declared dependencies found: > [WARNING] org.apache.ozone:hdds-hadoop-dependency-client:jar:2.0.0-SNAPSHOT:compile > [WARNING] org.apache.ozone:hdds-container-service:jar:2.0.0-SNAPSHOT:test > [WARNING] org.apache.ozone:hdds-hadoop-dependency-test:jar:2.0.0-SNAPSHOT:test > [WARNING] org.apache.ozone:hdds-server-framework:jar:2.0.0-SNAPSHOT:test > [WARNING] org.apache.ozone:hdds-server-scm:jar:2.0.0-SNAPSHOT:test > [WARNING] org.apache.ozone:hdds-test-utils:jar:2.0.0-SNAPSHOT:test > [WARNING] org.apache.ozone:ozone-manager:jar:2.0.0-SNAPSHOT:test > ``` `hdds-hadoop-dependency-client` and `hdds-hadoop-dependency-test` are special modules to get a consistent set of transitive dependencies from Hadoop, they don't have any code. `hdds-test-utils` has some utilities for tests, but is also a way to get multiple third-party libraries for tests like JUnit and Mockito. These are found as unused, but we would have to replace them with the many other dependencies to get rid of the finding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
