devabhishekpal commented on code in PR #7517:
URL: https://github.com/apache/ozone/pull/7517#discussion_r1870696285
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconScmTask.java:
##########
@@ -88,8 +94,12 @@ public boolean isRunning() {
}
protected void recordSingleRunCompletion() {
- reconTaskStatusDao.update(new ReconTaskStatus(getTaskName(),
- System.currentTimeMillis(), 0L));
+ taskStatusCounter.updateCounter(getTaskName(), true);
+ synchronized (this) {
+
reconTaskStatusRecord.setLastUpdatedTimestamp(System.currentTimeMillis());
+ reconTaskStatusRecord.setLastTaskRunStatus(1);
Review Comment:
As discussed we are using the exit code 0 for success and -1 for failure.
Addressed this in
[90c1997](https://github.com/apache/ozone/pull/7517/commits/90c1997d1a1c2906198d2117542ba2fa10869a56)
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/OzoneManagerServiceProviderImpl.java:
##########
@@ -575,13 +584,15 @@ public boolean syncDataFromOM() {
new OMDBUpdatesHandler(omMetadataManager)) {
LOG.info("Obtaining delta updates from Ozone Manager");
// Get updates from OM and apply to local Recon OM DB.
+ deltaUpdateTaskStatus.setCurrentTaskRunStatus(1);
getAndApplyDeltaUpdatesFromOM(currentSequenceNumber,
omdbUpdatesHandler);
// Update timestamp of successful delta updates query.
- ReconTaskStatus reconTaskStatusRecord = new ReconTaskStatus(
- OmSnapshotTaskName.OmDeltaRequest.name(),
- System.currentTimeMillis(), getCurrentOMDBSequenceNumber());
- reconTaskStatusDao.update(reconTaskStatusRecord);
+
deltaUpdateTaskStatus.setLastUpdatedSeqNumber(getCurrentOMDBSequenceNumber());
+ deltaUpdateTaskStatus.setCurrentTaskRunStatus(0);
+ deltaUpdateTaskStatus.setLastTaskRunStatus(1);
Review Comment:
Addressed in
[90c1997](https://github.com/apache/ozone/pull/7517/commits/90c1997d1a1c2906198d2117542ba2fa10869a56)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
