ashishkumar50 commented on code in PR #7349:
URL: https://github.com/apache/ozone/pull/7349#discussion_r1870810793
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java:
##########
@@ -238,6 +295,7 @@ public BackgroundTaskResult call() {
}
}
// place holder by returning empty results of this call back.
+ taskCount.getAndDecrement();
Review Comment:
Better to do `taskCount.getAndDecrement();` in finally. In case of some
exception it doesn't get decremented then from next time complete
DeletingService will halt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
